View unanswered posts | View active topics


Reply to topic  [ 15 posts ] 
Closing Braces 
Author Message
Member

Joined: Sat Sep 06, 2008 4:33 pm
Posts: 11
Post Closing Braces
Hi.
I think this feature should work a bit smarter.
If I type ( I should have () . But if I type () I should have () not ())
Same with quotes:
" —> ""
"" —> "" not """

Caret behavior:
"| -> "|"
""| -> ""|

Thanks for this feature!


Fri Oct 01, 2010 12:16 am
Profile
Admin

Joined: Wed Aug 31, 2005 7:27 am
Posts: 10735
Location: Paris, France
Post Re: Closing Braces
You're absolutely right.


Sat Oct 02, 2010 6:04 pm
Profile WWW
Member

Joined: Thu Mar 29, 2007 9:32 am
Posts: 244
Post Re: Closing Braces
fixed in trunk


Sun Oct 03, 2010 8:14 pm
Profile
Admin

Joined: Wed Aug 31, 2005 7:27 am
Posts: 10735
Location: Paris, France
Post Re: Closing Braces
Still hardly a good fix - I'm looking into doing something smarter.


Mon Oct 04, 2010 7:48 am
Profile WWW
Member

Joined: Mon Oct 16, 2006 12:02 am
Posts: 332
Location: Lviv, Ukraine
Post Re: Closing Braces
Autoclosing behaviour becomes totally corrupted for me.

I am typing:
Code:
toString();

It becomes
Code:
toString(
;


FD rev#1439

PS: #1437 works properly (without autoclosing)


Mon Oct 04, 2010 1:11 pm
Profile WWW
Admin

Joined: Tue Aug 30, 2005 6:14 pm
Posts: 2535
Location: Finland
Post Re: Closing Braces
Works here, in what context you use it?


Mon Oct 04, 2010 2:22 pm
Profile WWW
Member

Joined: Mon Oct 16, 2006 12:02 am
Posts: 332
Location: Lviv, Ukraine
Post Re: Closing Braces
It is already fixed
Revision: 1442
- bug when AutoCloseBrace is not enabled

However, autoclosing does not work for me. I tried clear ASComplete saved data, then restart FD.


Mon Oct 04, 2010 5:56 pm
Profile WWW
Admin

Joined: Tue Aug 30, 2005 6:14 pm
Posts: 2535
Location: Finland
Post Re: Closing Braces
Do you have it enabled? It is off by default.


Mon Oct 04, 2010 8:19 pm
Profile WWW
Member

Joined: Mon Oct 16, 2006 12:02 am
Posts: 332
Location: Lviv, Ukraine
Post Re: Closing Braces
You are right, I was looking to "Disable auto close braces" instead of "Add closing braces"

One more little bug when it is disabled:
type
Code:
trace(

then press Backspace
result:
Code:
trac

(should be trace)

And it would be useful if ProgramSettings dialog will remember last state (selected plugin and scroll position)


Tue Oct 05, 2010 6:55 am
Profile WWW
Admin

Joined: Tue Aug 30, 2005 6:14 pm
Posts: 2535
Location: Finland
Post Re: Closing Braces
I think Philippe just fixed that bug.


Tue Oct 05, 2010 7:37 am
Profile WWW
Member

Joined: Sat Sep 06, 2008 4:33 pm
Posts: 11
Post Re: Closing Braces
Thanks!

But why after Ctrl+Shift+Space anywhere in code it inserts )? :)


Tue Oct 05, 2010 6:54 pm
Profile
Admin

Joined: Wed Aug 31, 2005 7:27 am
Posts: 10735
Location: Paris, France
Post Re: Closing Braces
Fixed this other weird bug :)


Tue Oct 05, 2010 8:38 pm
Profile WWW
Member

Joined: Thu Mar 29, 2007 9:32 am
Posts: 244
Post Re: Closing Braces
how about dropping this buggy feature from trunk and moving to 3.4 branch?


Wed Oct 06, 2010 5:41 am
Profile
Admin

Joined: Tue Aug 30, 2005 6:14 pm
Posts: 2535
Location: Finland
Post Re: Closing Braces
It has some issues in some cases but i think its pretty ok. As it is disabled by default we can keep it for now. We'll improve it in next releases.


Wed Oct 06, 2010 6:21 am
Profile WWW
Member

Joined: Sat Sep 06, 2008 4:33 pm
Posts: 11
Post Re: Closing Braces
Now if type "" => """
Same with '' => '''

[] and {} works good.


Mon Nov 08, 2010 1:07 pm
Profile
Display posts from previous:  Sort by  
Reply to topic   [ 15 posts ] 

Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software for PTF.